parallel snstop #420
Open
parallel snstop #420
+199
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* parallel snstop * formatting fixes * added comments * added test - does it make sense? * fixed MPI check * actually fixing MPI check * iSort fix * maybe this time the test will be skipped? * maybe like this? * what about this * cleanup * add timeout option to testflo * rerun tests * updated test with send/receive --------- Co-authored-by: Marco Mangano <mmangano@umich.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 85.97% 85.99% +0.02%
==========================================
Files 22 22
Lines 3315 3335 +20
==========================================
+ Hits 2850 2868 +18
- Misses 465 467 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcomangano
previously approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to parallelize the SNSTOP user callback function.
See #417 for commit history.
A
--timeoutoption has been added to thetestfloarguments to avoid tests to hang.Expected time until merged
1 month
Type of change
Testing
Tests were added to ensure other processors are calling the snstop function.
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable