Install icu and datrie python packages from Ubuntu repos #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to cut the cross-platform image builds from 50 to 28 minutes. I would call this a success. |
philipkozeny
added a commit
to philipkozeny/nominatim-docker
that referenced
this pull request
Apr 1, 2025
philipkozeny
added a commit
to philipkozeny/nominatim-docker
that referenced
this pull request
Apr 1, 2025
philipkozeny
added a commit
to philipkozeny/nominatim-docker
that referenced
this pull request
Apr 1, 2025
|
Closed in favour of #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to try if this makes building the image any faster.
According to @lonvia pip is smart enough to figure out that the package already exists and doesn't compile them from scratch.