Skip to content

@algolia/client-search package version isn't set as peer dependancy #1403

@Fronix

Description

@Fronix

Description
The types in the @meilisearch/instant-search package uses algolias client-search types

import type {
  MultipleQueriesQuery as AlgoliaMultipleQueriesQuery,
  multipleSearchForFacetValues,
} from '@algolia/client-search'

These imports don't exist in newer versions and since meilisearch isn't requiring a version being installed you get type errors in the package which sets of typescript. So you are required to install @algolia/client-search v4.24.0 to remove the errors.

Expected behavior
I expect meilisearch packages to include their peer dependencies to avoid type errors and mismatching package versions

Current behavior
Getting type errors from meilisearch package

Screenshots or Logs

node_modules/@meilisearch/instant-meilisearch/src/types/types.ts:3:3 - error TS2305: Module '"@algolia/client-search"' has no exported member 'MultipleQueriesQuery'.

3   MultipleQueriesQuery as AlgoliaMultipleQueriesQuery,
    ~~~~~~~~~~~~~~~~~~~~

node_modules/@meilisearch/instant-meilisearch/src/types/types.ts:4:3 - error TS2305: Module '"@algolia/client-search"' has no exported member 'multipleSearchForFacetValues'.

4   multipleSearchForFacetValues,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/@meilisearch/instant-meilisearch/src/types/types.ts:3

Environment (please complete the following information):

  • instant-meilisearch version: v0.26.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions