Skip to content

Validator running against Core 2.6.9. #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ruhanga
Copy link
Contributor

@Ruhanga Ruhanga commented Feb 18, 2025

Upgrades validator to OpenMRS Core 2.6.9.

Affects: openmrs/openmrs-contrib-packager-maven-plugin#29

Copy link
Member

@mks-d mks-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ruhanga! I'm assuming this stems from the fact that the Validator's promise is to validate against the latest available Core version? I don't remember how this was originally set up to be honest.

public class BillableServicesLoaderIntegrationTest extends DomainBaseModuleContextSensitive_2_4_test {
public class BillableServicesLoaderIntegrationTest extends DomainBaseModuleContextSensitive_2_4_Test {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what got changed here? There's a bunch of files with similar changesets... 🤔

Copy link
Contributor Author

@Ruhanga Ruhanga Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, it has to do with changing from *_test to *_Test.

@mks-d mks-d changed the title Upgraded validator's OpenMRS core to 2.6.9. Validator running against Core 2.6.9. Feb 19, 2025
@Ruhanga
Copy link
Contributor Author

Ruhanga commented Feb 20, 2025

I'm assuming this stems from the fact that the Validator's promise is to validate against the latest available Core version? I don't remember how this was originally set up to be honest.

@mks-d, you're correct about the Validator's promise to validate against the latest available Core version. However, this hasn't been a priority in recent times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants