fix: handle JSON parsing errors in prompts #3588
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how custom prompts are handled when generating fact retrieval messages in the memory module. The main change is to allow a custom prompt to fully override the default system prompt logic, while ensuring the response must be valid JSON. The logic for constructing prompts has been centralized in the
getFactRetrievalMessagesfunction.Prompt customization improvements:
getFactRetrievalMessagesfunction now accepts an optionalcustomPromptparameter. If provided, it becomes the system prompt (with a requirement for valid JSON responses), and the user prompt is set to the parsed conversation. [1] [2]Memoryclass has been updated to always usegetFactRetrievalMessagesfor constructing prompts, passing incustomPromptif set, simplifying and unifying prompt handling.Fixes #3559
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist