Skip to content

Record object is unnecessary #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aehlke opened this issue Feb 17, 2025 · 1 comment
Open

Record object is unnecessary #194

aehlke opened this issue Feb 17, 2025 · 1 comment

Comments

@aehlke
Copy link

aehlke commented Feb 17, 2025

As far as I can tell, getRecord and the Record type is unnecessary and we can simply instantiate a CKRecord each time we upload

IceCream also doesn't save the CKRecord

Removing this saves a LOT of storage. I've done so in my fork and it seems to work ok. But maybe I'm missing something...

@aehlke
Copy link
Author

aehlke commented Mar 23, 2025

Oh I was wrong it's needed for conflict resolution (serverChangeTag)

I've added it back in my fork but I also started compressing the encoded record with facebook's Zstd using a dictionary based on the data records for better ratio

Zstd was able to compress each down to about 60 bytes per! lzfse was compressing to around 1500 bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant