Add missing packages, fix variable scoping bug #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moralrecordings
force-pushed
the
install_fix
branch
from
f213ab3 to
e653887
Compare
Not all devices have nfc. |
|
Okay, should that mean nfcd-binder-plugin doesn't belong on the list? As of now, if you try and run build_packages.sh in a clean environment, the process will crash because it can't find a bleeding-edge copy of nfcd in the standard repos. Is there any harm to building a package for nfcd/nfcd-binder-plugin if there isn't nfc support on the device? |
Previously buildmw would query the global DO_NOT_INSTALL, which is not guaranteed to be set by the parent call, leading to undefined behaviour.
moralrecordings
force-pushed
the
install_fix
branch
from
e653887 to
2f74759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the following: