Image retrieve functions #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geqie/cli.py
Outdated
| @@ -52,6 +52,13 @@ def _get_encoding_functions(params: Dict): | |||
| return EncodingFunctions(init_function, data_function, map_function) | |||
|
|
|||
|
|
|||
| def _get_retrive_functions(params: Dict): | |||
There was a problem hiding this comment.
Suggested change
| def _get_retrive_functions(params: Dict): | |
| def _get_retrive_function(params: Dict): |
geqie/cli.py
Outdated
| @@ -89,6 +96,15 @@ def wrapper(*args, **kwargs): | |||
| return wrapper | |||
|
|
|||
|
|
|||
| def retrieving_options(func): | |||
There was a problem hiding this comment.
Suggested change
| def retrieving_options(func): | |
| def retrive_options(func): |
geqie/cli.py
Outdated
| # print(f'Params: {params}') | ||
| print(f'Params.get("result"): {params.get("result")}') | ||
|
|
||
| retrieve_fun = _get_retrive_functions(params) |
There was a problem hiding this comment.
Suggested change
| retrieve_fun = _get_retrive_functions(params) | |
| retrieve_function = _get_retrive_function(params) |
geqie/cli.py
Outdated
| @retrieving_options | ||
| def retrieve(**params): | ||
| print('Retrieve CLI') | ||
| # print(f'Params: {params}') |
There was a problem hiding this comment.
can we remove the unnecessary comments?
geqie/encodings/frqi/retrieve.py
Outdated
|
|
||
| reconstructed_image = ones / total | ||
| try: | ||
| reconstructed_image = np.where(total > 0, ones / total, 0) |
There was a problem hiding this comment.
Do we need this try-except? I think we should just pad with zeros where NaN occurs, but I'm not sure how this behaves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image retrival code, for FRQI first.