Skip to content

Conversation

@Chetan-svg
Copy link

Implemented qr code feature and allowed for "Manage Inventory" and "Inventory Kit" feature in vendor-panel.

@vercel
Copy link

vercel bot commented Jun 4, 2025

@Chetan-svg is attempting to deploy a commit to the Rigby Team Team on Vercel.

A member of the Team first needs to authorize it.

@kactok kactok mentioned this pull request Dec 1, 2025
@kactok
Copy link
Collaborator

kactok commented Dec 1, 2025

Hi @Chetan-svg, I noticed that you created two very similar PRs, or possibly even the exact same PR #106. I’m closing the other one and will respond here as feedback for both.

This is quite a large PR (around 9k lines affected), so we’re not able to merge it in its current form. For future contributions, I would recommend splitting the work into smaller, more manageable chunks; this makes it much easier to review and to revert if anything goes wrong.

This PR also touches multiple areas such as auth, filters, sorting, and even introduces a new feature with QR codes. Some of these features appear to be tailored for very specific custom needs, and we try to avoid adding such customizations directly to the core codebase to keep it flexible and maintainable for all users.

Regarding filters; we’re progressively adding them across all views, so if something is missing now, it will most likely appear in the near future. The QR code feature is interesting and could be considered as a potential improvement, but it’s not something we are planning to introduce at this moment.

It would also be very helpful if you could attach some recordings or screenshots showcasing the changes; this makes it much easier for us to understand the intention and behaviour of the PR.

@kactok kactok closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants