Fix/mm2 1362: Typescript errors pt 4

package.json

@@ -12,7 +12,9 @@
     "i18n:validate": "node ./scripts/i18n/validate-translation.js",
     "i18n:schema": "node ./scripts/i18n/generate-schema.js",
     "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
-    "format": "prettier --write ."
+    "format": "prettier --write .",
+    "ts-check": "node ./scripts/ts-check.js > ts-errors.log 2>&1 && echo 'TypeScript check complete. Results saved to ts-errors.log'",
+    "typecheck": "tsc --noEmit"
   },
   "main": "dist/app.js",
   "module": "dist/app.mjs",
@@ -84,6 +86,7 @@
     "@medusajs/admin-vite-plugin": "^2.5.0",
     "@medusajs/types": "^2.5.0",
     "@medusajs/ui-preset": "^2.5.0",
+    "@types/lodash": "^4.17.20",
     "@types/node": "^20.11.15",
     "@types/react": "^18.2.79",
     "@types/react-dom": "^18.2.25",

scripts/ts-check.js

@@ -0,0 +1,87 @@
+// scripts/ts-check.js
+// Scans src/**/*.{ts,tsx} and uses tsconfig.json compilerOptions (so JSX settings are respected).
+
+const ts = require("typescript")
+const glob = require("glob")
+const path = require("path")
+
+// 1) Collect files under /src
+const files = glob.sync("src/**/*.{ts,tsx}", { absolute: true })
+
+if (files.length === 0) {
+  console.log("No TypeScript files found under /src.")
+  process.exit(0)
+}
+
+// 2) Try to find and parse tsconfig.json to reuse compilerOptions (important for JSX)
+let compilerOptions = {}
+const configPath = ts.findConfigFile(
+  process.cwd(),
+  ts.sys.fileExists,
+  "tsconfig.json"
+)
+
+if (configPath) {
+  const parsed = ts.getParsedCommandLineOfConfigFile(configPath, {}, ts.sys)
+  if (parsed && parsed.options) {
+    compilerOptions = parsed.options
+  } else {
+    console.warn(
+      "Warning: Couldn't fully parse tsconfig.json — falling back to defaults."
+    )
+  }
+} else {
+  console.warn("Warning: No tsconfig.json found. Using sensible defaults.")
+}
+
+// 3) Ensure we don't emit and skip noisy lib checks
+compilerOptions = Object.assign({}, compilerOptions, {
+  noEmit: true,
+  skipLibCheck: true,
+})
+
+// 4) Create program with the explicit file list (so we ignore tsconfig includes/excludes)
+const program = ts.createProgram(files, compilerOptions)
+
+// 5) Collect diagnostics
+const diagnostics = ts.getPreEmitDiagnostics(program)
+
+if (diagnostics.length === 0) {
+  console.log(`✅ No TypeScript errors found in ${files.length} files.`)
+  process.exit(0)
+}
+
+// 6) Print diagnostics in "file:line:col - error TS..." form and collect stats
+let errorCount = 0
+const filesWithErrors = new Set()
+
+diagnostics.forEach((diag) => {
+  if (diag.file) {
+    const { line, character } = diag.file.getLineAndCharacterOfPosition(
+      diag.start
+    )
+    const message = ts.flattenDiagnosticMessageText(diag.messageText, "\n")
+    const relativeFile = path.relative(process.cwd(), diag.file.fileName)
+
+    console.log(
+      `${relativeFile}:${line + 1}:${character + 1} - error TS${diag.code}: ${message}`
+    )
+
+    errorCount++
+    filesWithErrors.add(relativeFile)
+  } else {
+    // global/unbound diagnostic
+    console.log(
+      `error TS${diag.code}: ${ts.flattenDiagnosticMessageText(diag.messageText, "\n")}`
+    )
+    errorCount++
+  }
+})
+
+// 7) Summary
+console.log("\n--- TypeScript Check Summary ---")
+console.log(`Scanned files:      ${files.length}`)
+console.log(`Files with errors:  ${filesWithErrors.size}`)
+console.log(`Total errors:       ${errorCount}`)
+
+process.exit(0)

src/components/search/use-search-results.tsx

@@ -720,7 +720,7 @@ const transformMap: TransformMap = {
   },
 }
 
-function transformDynamicSearchResults<T extends { count: number }>(
+function transformDynamicSearchResults<T extends { count?: number }>(
   type: SearchArea,
   limit: number,
   t: TFunction,
@@ -737,11 +737,13 @@ function transformDynamicSearchResults<T extends { count: number }>(
     return undefined
   }
 
+  const count = response.count ?? 0
+
   return {
     title: t(`app.search.groups.${type}`),
     area: type,
-    hasMore: response.count > limit,
-    count: response.count,
+    hasMore: count > limit,
+    count,
     items: data.map(transform),
   }
 }

src/components/table/data-table/data-table-order-by/data-table-order-by.tsx

@@ -4,8 +4,9 @@ import { useState } from "react"
 import { useTranslation } from "react-i18next"
 import { useSearchParams } from "react-router-dom"
 
+
 export type DataTableOrderByKey<TData> = {
-  key: keyof TData
+  key: keyof TData | (string & Record<never, never>)
   label: string
 }
 

src/components/table/table-cells/product/variant-cell/variant-cell.tsx

@@ -1,10 +1,10 @@
 import { useTranslation } from "react-i18next"
 
 import { PlaceholderCell } from "../../common/placeholder-cell"
-import { HttpTypes } from "@medusajs/types"
+import { ExtendedAdminProductVariant } from "../../../../../types/extended-product"
 
 type VariantCellProps = {
-  variants?: HttpTypes.AdminProductVariant[] | null
+  variants?: ExtendedAdminProductVariant[] | null
 }
 
 export const VariantCell = ({ variants }: VariantCellProps) => {

src/extensions/forms/form-extension-zone/form-extension-zone.tsx

@@ -1,18 +1,21 @@
 import { InlineTip, Input, Switch } from "@medusajs/ui"
 import { ComponentType } from "react"
-import { ControllerRenderProps, UseFormReturn } from "react-hook-form"
+import { ControllerRenderProps, FieldPath, FieldValues, UseFormReturn } from "react-hook-form"
 import { useTranslation } from "react-i18next"
 import { Form } from "../../../components/common/form"
 import { FormField } from "../../types"
 import { FormFieldType } from "./types"
 import { getFieldType } from "./utils"
 
-type FormExtensionZoneProps = {
+type FormExtensionZoneProps<TFieldValues extends FieldValues = FieldValues> = {
   fields: FormField[]
-  form: UseFormReturn<any>
+  form: UseFormReturn<TFieldValues>
 }
 
-export const FormExtensionZone = ({ fields, form }: FormExtensionZoneProps) => {
+export const FormExtensionZone = <TFieldValues extends FieldValues = FieldValues>({ 
+  fields, 
+  form 
+}: FormExtensionZoneProps<TFieldValues>) => {
   return (
     <div>
       {fields.map((field, index) => (
@@ -33,12 +36,15 @@ function getFieldLabel(field: FormField) {
     .join(" ")
 }
 
-type FormExtensionFieldProps = {
+type FormExtensionFieldProps<TFieldValues extends FieldValues = FieldValues> = {
   field: FormField
-  form: UseFormReturn<any>
+  form: UseFormReturn<TFieldValues>
 }
 
-const FormExtensionField = ({ field, form }: FormExtensionFieldProps) => {
+const FormExtensionField = <TFieldValues extends FieldValues = FieldValues>({ 
+  field, 
+  form 
+}: FormExtensionFieldProps<TFieldValues>) => {
   const label = getFieldLabel(field)
   const description = field.description
   const placeholder = field.placeholder
@@ -51,7 +57,7 @@ const FormExtensionField = ({ field, form }: FormExtensionFieldProps) => {
   return (
     <Form.Field
       control={control}
-      name={`additional_data.${field.name}`}
+      name={`additional_data.${field.name}` as FieldPath<TFieldValues>}
       render={({ field }) => {
         return (
           <Form.Item>
@@ -73,19 +79,25 @@ const FormExtensionField = ({ field, form }: FormExtensionFieldProps) => {
   )
 }
 
-type FormExtensionFieldComponentProps = {
-  field: ControllerRenderProps
+type FormExtensionFieldComponentProps<
+  TFieldValues extends FieldValues = FieldValues,
+  TName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>
+> = {
+  field: ControllerRenderProps<TFieldValues, TName>
   type: FormFieldType
-  component?: ComponentType<any>
+  component?: ComponentType<ControllerRenderProps<TFieldValues, TName> & { placeholder?: string }>
   placeholder?: string
 }
 
-const FormExtensionFieldComponent = ({
+const FormExtensionFieldComponent = <
+  TFieldValues extends FieldValues = FieldValues,
+  TName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>
+>({
   field,
   type,
   component,
   placeholder,
-}: FormExtensionFieldComponentProps) => {
+}: FormExtensionFieldComponentProps<TFieldValues, TName>) => {
   const { t } = useTranslation()
 
   if (component) {