Move torchtnt to arc pyre
#1017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D78682161 |
alanhdu
added a commit
to alanhdu/tnt
that referenced
this pull request
Jul 23, 2025
Summary: Turn `python.set_typing(True)` on and remove the old pyre configuration. This opts into the per-target type-checking (e.g. `arc pyre check-changed-targets`). See https://www.internalfb.com/wiki/Python/Type-annotations-in-python/How_To%3A_Migrate_to_Pyre_Fast_By_Default_Per_Target_Type_Checking/ Reviewed By: diego-urgell Differential Revision: D78682161
alanhdu
force-pushed
the
export-D78682161
branch
from
b191a34 to
9f84d16
Compare
Summary: Pull Request resolved: meta-pytorch#1017 Turn `python.set_typing(True)` on and remove the old pyre configuration. This opts into the per-target type-checking (e.g. `arc pyre check-changed-targets`). See https://www.internalfb.com/wiki/Python/Type-annotations-in-python/How_To%3A_Migrate_to_Pyre_Fast_By_Default_Per_Target_Type_Checking/ Reviewed By: diego-urgell Differential Revision: D78682161
|
This pull request was exported from Phabricator. Differential Revision: D78682161 |
alanhdu
force-pushed
the
export-D78682161
branch
from
9f84d16 to
0df747b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Turn
python.set_typing(True)on and remove the old pyre configuration. This opts into the per-target type-checking (e.g.arc pyre check-changed-targets).See https://www.internalfb.com/wiki/Python/Type-annotations-in-python/How_To%3A_Migrate_to_Pyre_Fast_By_Default_Per_Target_Type_Checking/
Differential Revision: D78682161