Create Callback to Identify Empty Batches #1020
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D79212756 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Aug 1, 2025
Summary: # This Diff: This diff implements Step 1 of T232701473 by creating EmptyDataloaderDetectorCallback, a TNT callback that detects consecutive empty training epochs and implements a fail-fast strategy to surface dataloader issues early. # Callback Feature: The callback helps identify cases where dataloaders return empty batches, which can cause confusing downstream issues that manifest as red herrings (e.g., apparent checkpointing errors that are actually rapid step progression due to empty data). # Next Diff: Add to Mitra's default callbacks (Step 2 of T232701473) Differential Revision: D79212756
supergeorge23
force-pushed
the
export-D79212756
branch
from
45926e8 to
3db932d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79212756 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Aug 1, 2025
Summary: # This Diff: This diff implements Step 1 of T232701473 by creating EmptyDataloaderDetectorCallback, a TNT callback that detects consecutive empty training epochs and implements a fail-fast strategy to surface dataloader issues early. # Callback Feature: The callback helps identify cases where dataloaders return empty batches, which can cause confusing downstream issues that manifest as red herrings (e.g., apparent checkpointing errors that are actually rapid step progression due to empty data). # Next Diff: Add to Mitra's default callbacks (Step 2 of T232701473), and will enable e2e test with Mitra Differential Revision: D79212756
supergeorge23
force-pushed
the
export-D79212756
branch
from
3db932d to
8153d62
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79212756 |
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Aug 1, 2025
Summary: Pull Request resolved: meta-pytorch#1020 # This Diff: This diff implements Step 1 of T232701473 by creating EmptyDataloaderDetectorCallback, a TNT callback that detects consecutive empty training epochs and implements a fail-fast strategy to surface dataloader issues early. # Callback Feature: The callback helps identify cases where dataloaders return empty batches, which can cause confusing downstream issues that manifest as red herrings (e.g., apparent checkpointing errors that are actually rapid step progression due to empty data). # Next Diff: Add to Mitra's default callbacks (Step 2 of T232701473), and will enable e2e test with Mitra Differential Revision: D79212756
supergeorge23
force-pushed
the
export-D79212756
branch
2 times, most recently
from
6c43d86 to
4ec1115
Compare
supergeorge23
added a commit
to supergeorge23/tnt
that referenced
this pull request
Aug 4, 2025
Summary: # This Diff: This diff implements Step 1 of T232701473 by creating EmptyDataloaderDetectorCallback, a TNT callback that detects consecutive empty training epochs and implements a fail-fast strategy to surface dataloader issues early. # Callback Feature: The callback helps identify cases where dataloaders return empty batches, which can cause confusing downstream issues that manifest as red herrings (e.g., apparent checkpointing errors that are actually rapid step progression due to empty data). # Next Diff: Add to Mitra's default callbacks (Step 2 of T232701473), and will enable e2e test with Mitra Differential Revision: D79212756
|
This pull request was exported from Phabricator. Differential Revision: D79212756 |
Summary: # This Diff: This diff implements Step 1 of T232701473 by creating EmptyDataloaderDetectorCallback, a TNT callback that detects consecutive empty training epochs and implements a fail-fast strategy to surface dataloader issues early. # Callback Feature: The callback helps identify cases where dataloaders return empty batches, which can cause confusing downstream issues that manifest as red herrings (e.g., apparent checkpointing errors that are actually rapid step progression due to empty data). # Next Diff: Add to Mitra's default callbacks (Step 2 of T232701473), and will enable e2e test with Mitra Differential Revision: D79212756
supergeorge23
force-pushed
the
export-D79212756
branch
from
4ec1115 to
70351b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79212756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff:
This diff implements Step 1 of T232701473 by creating EmptyDataloaderDetectorCallback,
a TNT callback that detects consecutive empty training epochs and implements a fail-fast
strategy to surface dataloader issues early.
Callback Feature:
The callback helps identify cases where dataloaders return empty batches, which can
cause confusing downstream issues that manifest as red herrings (e.g., apparent
checkpointing errors that are actually rapid step progression due to empty data).
Next Diff:
Add to Mitra's default callbacks (Step 2 of T232701473)
Differential Revision: D79212756