Calculate _step_requires_iterator only once #1025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D80776986 |
Summary: Minor optimisation opportunity that I noticed when poking around in here. `_step_requires_iterator` uses the `inspect` module to look at type hints. This is somewhat expensive (tens of microseconds), so you probably don't want to recalculate it on every batch. It should be constant, so we can calculate it once during init. Alternatively, we could stick a `funcutils.cache` decorator on `_step_requires_iterator`. That has its pros and cons, LMK if you think it's better. Reviewed By: galrotem Differential Revision: D80776986
aelavender
force-pushed
the
export-D80776986
branch
from
f7b9176 to
d951a88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80776986 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Minor optimisation opportunity that I noticed when poking around in here.
_step_requires_iteratoruses theinspectmodule to look at type hints. This is somewhat expensive (tens of microseconds), so you probably don't want to recalculate it on every batch. It should be constant, so we can calculate it once during init.Alternatively, we could stick a
funcutils.cachedecorator on_step_requires_iterator. That has its pros and cons, LMK if you think it's better.Reviewed By: galrotem
Differential Revision: D80776986