Fixup Optional runopt cfg values handling during cfg_from_json_repr deserialization #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eserialization Summary: Handle default to None types in runopts for derserialization API Differential Revision: D68445341
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68445341 |
lgarg26
requested review from
Sanjay-Ganeshan,
andywag,
ishachirimar and
jesszzzz
jesszzzz
approved these changes
Jan 21, 2025
ishachirimar
approved these changes
Jan 21, 2025
facebook-github-bot
merged commit 4789001
into
meta-pytorch:main
22 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Handle default to None types in runopts for derserialization API
Differential Revision: D68445341