Skip to content

fbcode//torchx/runner/test [A] #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fbcode//torchx/runner/test [A] #1003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torchx/runner/test/api_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ def test_status_ui_url(self, json_dumps_mock: MagicMock, _) -> None:
)
app_handle = runner.run(AppDef(app_id, roles=[role]), scheduler="local_dir")
status = none_throws(runner.status(app_handle))
self.assertEquals(resp.ui_url, status.ui_url)
self.assertEqual(resp.ui_url, status.ui_url)

@patch("json.dumps")
def test_status_structured_msg(self, json_dumps_mock: MagicMock, _) -> None:
Expand All @@ -493,7 +493,7 @@ def test_status_structured_msg(self, json_dumps_mock: MagicMock, _) -> None:
)
app_handle = runner.run(AppDef(app_id, roles=[role]), scheduler="local_dir")
status = none_throws(runner.status(app_handle))
self.assertEquals(resp.structured_error_msg, status.structured_error_msg)
self.assertEqual(resp.structured_error_msg, status.structured_error_msg)

def test_wait_unknown_app(self, _) -> None:
with self.get_runner() as runner:
Expand Down
Loading