feat: add aws_p5en.48xlarge #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
@d4l3k please check if you can |
Collaborator
Author
|
Any chance we can incorporate this change? @tonykao8080 @d4l3k |
Contributor
|
@clumsy PR is approved. there is pending lint check. not sure how it got stucked. can you make some change (e.g. comment) and see if that retrigger the lint check? |
Collaborator
Author
|
Sure, @tonykao8080 let me rebase and force push |
clumsy
force-pushed
the
feat/aws_p5en_48xlarge
branch
from
c799ea8 to
b0eff99
Compare
Collaborator
Author
|
@tonykao8080 the linter passes, the docs fail for seemingly unrelated change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new AWS GPU-enabled instance type:
aws_p5en.48xlargeSee the details and spec in https://aws.amazon.com/ec2/instance-types/p5
Test plan:
[x] unit test added
[x] submitted AWS Batch job