Skip to content

Conversation

@njriasan
Copy link
Contributor

Adds a web frontend for IR Analysis focused on BufferOPs. Also cleans up the existing backend to better conform with the frontend code. Screenshot display is attached.

Screenshot 2025-10-25 at 6 25 41 PM

Warning: Most of this is written with DevMate because I barely know JS.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 25, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 25, 2025

@njriasan has imported this pull request. If you are a Meta employee, you can view this in D85508301.

</div>
<div className="flex flex-col">
<span className="text-sm font-medium text-gray-500">Tiled Buffer Store Count</span>
<span className="font-mono text-sm break-words">{ttgir_info["tt.store_count"] ?? "NaN"}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ttgir_info exists while amdgpu.buffer_load_count not, it will show undefined rather than NaN.
considering to add a getCount function to safely access it.

const getCount = (info: Record<string, number> | undefined, key: string): string => {
  return info?.[key]?.toString() ?? "N/A";
};

<span className="font-mono text-sm">
  {getCount(ttgir_info, "tt.load_count")}
</span>

{amdgcn_info && (
<>
<div className="flex flex-col">
<span className="text-sm font-medium text-gray-500">AMDGCN Buffer Load Instruction Count</span>
Copy link
Member

@FindHao FindHao Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMDGCN Buffer Load Instruction Count -> amdgcn_info["global_load_count"], and the below is AMDGCN Global Load Instruction Count -> amdgcn_info["buffer_load_count"]. Looks like the buffer load used global_load while global load used buffer_load.

Are they supposed to be reversed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree. Thanks for the feedback.

@njriasan njriasan requested a review from FindHao October 27, 2025 16:04
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution! IR analysis is a really nice feature. I feel it can be easily extended and help the automation triton pin upgrade ci tests failure analysis a lot!

@meta-codesync
Copy link

meta-codesync bot commented Oct 27, 2025

@njriasan merged this pull request in cc29ee8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants