-
Couldn't load subscription status.
- Fork 12
[BE] [TritonParse] Add a web frontend for IR Analysis #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Pull Request resolved: meta-pytorch#182 Differential Revision: D85376311
website/src/pages/IRAnalysis.tsx
Outdated
| </div> | ||
| <div className="flex flex-col"> | ||
| <span className="text-sm font-medium text-gray-500">Tiled Buffer Store Count</span> | ||
| <span className="font-mono text-sm break-words">{ttgir_info["tt.store_count"] ?? "NaN"}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If ttgir_info exists while amdgpu.buffer_load_count not, it will show undefined rather than NaN.
considering to add a getCount function to safely access it.
const getCount = (info: Record<string, number> | undefined, key: string): string => {
return info?.[key]?.toString() ?? "N/A";
};
<span className="font-mono text-sm">
{getCount(ttgir_info, "tt.load_count")}
</span>
website/src/pages/IRAnalysis.tsx
Outdated
| {amdgcn_info && ( | ||
| <> | ||
| <div className="flex flex-col"> | ||
| <span className="text-sm font-medium text-gray-500">AMDGCN Buffer Load Instruction Count</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMDGCN Buffer Load Instruction Count -> amdgcn_info["global_load_count"], and the below is AMDGCN Global Load Instruction Count -> amdgcn_info["buffer_load_count"]. Looks like the buffer load used global_load while global load used buffer_load.
Are they supposed to be reversed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree. Thanks for the feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution! IR analysis is a really nice feature. I feel it can be easily extended and help the automation triton pin upgrade ci tests failure analysis a lot!
Adds a web frontend for IR Analysis focused on BufferOPs. Also cleans up the existing backend to better conform with the frontend code. Screenshot display is attached.
Warning: Most of this is written with DevMate because I barely know JS.