Use AlgorithmEnum in artist similarity labs API #3343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do the same for recording similarity, porting the logic over to artist similarity
|
@amCap1712 I have no idea how to test this, asking for your help :) As far as I could tell we don't have our test setup available to access labs API running on test, and I don;t have the required data locally to test it that way either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While pointing out the existence of the similarity endpoints to a user, I realized the recording similarity page can be used without much prior knowledge because the algorithm input is a dropdown with the available options.
The artist similarity page on the other hand does not have that, requiring that you know the magic string that will make this incantation work.
Porting the logic over from recording to artist similarity, although I don't exactly know how to test this.