Refactor listencard #3372
Open
Refactor listencard #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also partly fixes issue LB-1643
When manually mapping a track, teh serach endpoint does not return all the metadata we have, resulting in a listen that looks partially matched. Fetching more metadata to make the instant feedback more gratifying.
anshg1214
requested changes
Sep 13, 2025
| <div className="main-content"> | ||
| {beforeThumbnailContent} | ||
| {thumbnail} | ||
| {listenDetails || ( |
There was a problem hiding this comment.
You need to revert this change and add a parent div with class listen-details.
The top-album and top-track stats break because of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating LB-1643, I realized our stopgap solution of using a functional component wrapper (to be able to use react hooks) on top of a class component means that after manually mapping a listen the cover art does not update.
The cover art cache is set up in the wrapper, and no information is brought back to the wrapper from the class component after matching.
So it is finally time to rewrite the ListenCard into a functional component.
For LB-1643, I also added an extra step of fetching from the LB metadata cache API so that for the user's visual feedback the listen appears completely matched (instead for example of missing artist link).
Perhaps we could instead modify the recording-search API response to return artist MBID(s)?