Merge pull request #3629 from mwiencek/flow-281

Upgrade Flow to v0.283.0

Author: mwiencek

.github/workflows/ci.yml

@@ -9,7 +9,7 @@ on:
       - translations
 
 env:
-  TESTS_IMAGE_TAG: v-2025-08-29.1
+  TESTS_IMAGE_TAG: v-2025-09-27.0
 
 jobs:
   build-tests-image:

eslint.config.mjs

@@ -773,9 +773,8 @@ export default [
       'ft-flow/no-internal-flow-type': 'warn',
       'ft-flow/no-duplicate-type-union-intersection-members': 'warn',
       'ft-flow/no-existential-type': 'warn',
-      'ft-flow/no-flow-fix-me-comments': 'error',
       'ft-flow/no-flow-suppressions-in-strict-files': ['warn', {
-        "$FlowIssue": false,
+        "$FlowExpectedError": false,
       }],
       'ft-flow/no-internal-flow-type': 'warn',
       'ft-flow/no-mixed': 'off',

package.json

@@ -82,7 +82,7 @@
     "eslint-plugin-react": "7.37.5",
     "eslint-plugin-react-hooks": "6.1.0-canary-4db4b21c-20250626",
     "eslint-plugin-simple-import-sort": "^7.0.0",
-    "flow-bin": "0.275.0",
+    "flow-bin": "0.283.0",
     "flow-typed": "4.1.1",
     "gettext-parser": "4.2.0",
     "globals": "15.9.0",

root/admin/attributes/AttributeEditForm.js

@@ -21,7 +21,7 @@ component AttributeEditForm(...props: CreateOrEditAttributePropsT) {
     {type: 'Language', const form, ...} => <LanguageEditForm form={form} />,
     {type: 'Script', const form, ...} => <ScriptEditForm form={form} />,
     {type: 'CollectionType' | 'SeriesType', ...} as props => (
-      // $FlowIssue[incompatible-type] series vs collection confuses Flow
+      // $FlowExpectedError[incompatible-type] series/collection confuses Flow
       <AttributeEditFormWithEntityType
         action={props.action}
         entityTypeSelectOptions={props.entityTypeSelectOptions}

root/edit/details/AddArt.js

@@ -28,7 +28,7 @@ component AddArt(
       <tr>
         <th>{addColonText(formattedEntityType)}</th>
         <td>
-          {/* $FlowIgnore[prop-missing] */}
+          {/* $FlowFixMe[prop-missing] */}
           <DescriptiveLink entity={display[entityType]} />
         </td>
       </tr>
@@ -62,7 +62,7 @@ component AddArt(
 
       <EditArtwork
         artwork={display.artwork}
-        // $FlowIgnore[prop-missing]
+        // $FlowFixMe[prop-missing]
         entity={display[entityType]}
       />
     </table>

root/edit/details/EditArt.js

@@ -44,7 +44,7 @@ component EditArt(
       <tr>
         <th>{addColonText(formattedEntityType)}</th>
         <td colSpan={2}>
-          {/* $FlowIgnore[prop-missing] */}
+          {/* $FlowFixMe[prop-missing] */}
           <DescriptiveLink entity={display[entityType]} />
         </td>
       </tr>
@@ -80,7 +80,7 @@ component EditArt(
       <EditArtwork
         artwork={display.artwork}
         colSpan={2}
-        // $FlowIgnore[prop-missing]
+        // $FlowFixMe[prop-missing]
         entity={display[entityType]}
       />
     </table>

root/edit/details/RemoveArt.js

@@ -28,7 +28,7 @@ component RemoveArt(
       <tr>
         <th>{addColonText(formattedEntityType)}</th>
         <td>
-          {/* $FlowIgnore[prop-missing] */}
+          {/* $FlowFixMe[prop-missing] */}
           <DescriptiveLink entity={display[entityType]} />
         </td>
       </tr>
@@ -64,7 +64,7 @@ component RemoveArt(
 
       <EditArtwork
         artwork={display.artwork}
-        // $FlowIgnore[prop-missing]
+        // $FlowFixMe[prop-missing]
         entity={display[entityType]}
       />
     </table>

root/edit/details/ReorderArt.js

@@ -22,7 +22,7 @@ component ReorderArt(
   formattedEntityType: string,
 ) {
   const display = edit.display_data;
-  // $FlowIgnore[prop-missing]
+  // $FlowFixMe[prop-missing]
   const entity = display[entityType];
   const oldArt = display.old;
   const newArt = display.new;
@@ -40,7 +40,7 @@ component ReorderArt(
       <tr>
         <th>{addColonText(formattedEntityType)}</th>
         <td>
-          {/* $FlowIgnore[prop-missing] */}
+          {/* $FlowFixMe[prop-missing] */}
           <DescriptiveLink entity={entity} />
         </td>
       </tr>

root/entity/NotFound.js

@@ -11,7 +11,8 @@
 import NotFoundComponent from '../components/NotFound.js';
 import expand2react from '../static/scripts/common/i18n/expand2react.js';
 
-const defaultSearchArgs = {search_url: '/search'};
+const defaultSearchArgs: NotFoundPagesPropsT['args'] =
+  {search_url: '/search'};
 
 type NotFoundPagesPropsT = {
   +args: {genre_list?: string, search_url?: string},

root/release/DiscIds.js

@@ -101,7 +101,7 @@ component DiscIds(
             </tr>
           </thead>
           <tbody>
-            {/* $FlowIgnore[incompatible-use] has cdtocs so has mediums */}
+            {/* $FlowFixMe[incompatible-use] has cdtocs so has mediums */}
             {release.mediums.map(medium => {
               const mediumCDTocs = groupedMediumCDTocs.get(medium.id) ?? [];
               return (