-
-
Notifications
You must be signed in to change notification settings - Fork 299
MBS-14013: replace date editor with a react component #3540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
unlike the perl component, react validates the date range
Tests fail because HydratedDateRangeFieldset is missing begin/end area |
date range component can now optionally have begin/end area components
@reosarevok did you have a chance to review this? |
BTW, @reosarevok I did this before you asked me to consult you before implementing features in #3565 (comment) (although this is not a style issue so maybe that's not needed). |
No, this is not style so that doesn't matter :) I haven't had time to check this (just came back from a holiday) but I will try to find some time. Did you manage to make it "support different labels per artist type" now? :) |
No rush, I just wanted to know if you plan to review it or not. |
Tested this locally and it does work, but @mwiencek might have comments about the code itself, so I'd want his review here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! There's one bug which needs to be resolved, and it might take a bit of effort.
- introduce HydratedArtistDateRangeFieldset component - add option to customize hidden id field in Autocomplete2 as artist form uses area_id instead of the default area.id
Problem
MBS-14013: entity create fails silently when begin date > end date
Solution
replace artist date editor with a react component