MBS-14053 (server): Add ended flag to aliases #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAICT we were only testing the most basic alias display in the API, namely aliases with sortnames and nothing else. This adds testing for begin and end dates, types, and locale + primary.
This adds "ended" to aliases in XML to match what we already do in JSON. While ideally we would probably add a life-span element to aliases, that would be a big change given we already do dates as attributes, so it's probably better left for ws/3. For now, this matches what we do for the "primary" boolean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-14053 (II)
Description
This adds an
endedattribute to aliases in XML to match what we already do in JSON. While ideally we would probably add alife-spanelement to aliases, that would be a big change given we already do dates as attributes, so it's probably better left for ws/3. For now, this matches what we do for theprimaryboolean.Associated mmd-schema PR: metabrainz/mmd-schema#42
Testing
Added checks for this to the API tests. Additionally, since we weren't really testing aliases in the API other than the entirely bare minimum, added checks for the rest of the alias attributes on a separate commit.