remove join parameter

The join feature is something we try to add on top of Elasticsearch. It
complicates our interactions with external queries and we don't use them
anywhere in our own code.

Author: haarg

lib/MetaCPAN/Server/Controller.pm

@@ -128,90 +128,6 @@ sub search : Path('_search') : ActionClass('~Deserialize') {
     } or do { $self->internal_error( $c, $@ ) };
 }
 
-sub join : ActionClass('~Deserialize') {
-    my ( $self, $c ) = @_;
-    my $joins     = $self->relationships;
-    my @req_joins = $c->req->param('join');
-    my $is_get    = ref $c->stash->{hits} ? 0 : 1;
-    my $query
-        = $c->req->params->{q}
-        ? { query => { query_string => { query => $c->req->params->{q} } } }
-        : $c->req->data ? $c->req->data
-        :                 { query => { match_all => {} } };
-    $c->detach(
-        '/not_allowed',
-        [
-            'unknown join type, valid values are '
-                . Moose::Util::english_list( keys %$joins )
-        ]
-    ) if ( scalar grep { !$joins->{$_} } @req_joins );
-
-    while ( my ( $join, $config ) = each %$joins ) {
-        my $has_many = ref $config->{type};
-        my ($type)   = $has_many ? @{ $config->{type} } : $config->{type};
-        my $cself    = $config->{self} || $join;
-        next unless ( grep { $_ eq $join } @req_joins );
-        my $data
-            = $is_get
-            ? [ $c->stash ]
-            : [
-            map {
-                $_->{_source}
-                    || single_valued_arrayref_to_scalar( $_->{fields} )
-            } @{ $c->stash->{hits}->{hits} }
-            ];
-        my @ids = List::AllUtils::uniq grep {defined}
-            map { ref $cself eq 'CODE' ? $cself->($_) : $_->{$cself} } @$data;
-        my $filter   = { terms => { $config->{foreign} => [@ids] } };
-        my $filtered = {%$query};    # don't work on $query
-        $filtered->{filter}
-            = $query->{filter}
-            ? { and => [ $filter, $query->{filter} ] }
-            : $filter;
-        my $foreign = eval {
-            $c->model("CPAN::$type")->query( $filtered->{query} )
-                ->filter( $filtered->{filter} )->size(1000)->raw->all;
-        } or do { $self->internal_error( $c, $@ ) };
-        $c->detach(
-            "/not_allowed",
-            [
-                'The number of joined documents exceeded the allowed number of 1000 documents by '
-                    . ( $foreign->{hits}->{total} - 1000 )
-                    . '. Please reduce the number of documents or apply additional filters.'
-            ]
-        ) if ( $foreign->{hits}->{total} > 1000 );
-        $c->stash->{took} += $foreign->{took} unless ($is_get);
-
-        if ($has_many) {
-            my $many;
-            for ( @{ $foreign->{hits}->{hits} } ) {
-                my $list = $many->{ $_->{_source}->{ $config->{foreign} } }
-                    ||= [];
-                push( @$list, $_ );
-            }
-            $foreign = $many;
-        }
-        else {
-            $foreign = { map { $_->{_source}->{ $config->{foreign} } => $_ }
-                    @{ $foreign->{hits}->{hits} } };
-        }
-        for (@$data) {
-            my $key = ref $cself eq 'CODE' ? $cself->($_) : $_->{$cself};
-            next unless ($key);
-            my $result = $foreign->{$key};
-            $_->{$join}
-                = $has_many
-                ? {
-                hits => {
-                    hits  => $result,
-                    total => scalar @{ $result || [] }
-                }
-                }
-                : $result;
-        }
-    }
-}
-
 sub not_found : Private {
     my ( $self, $c ) = @_;
     $c->cdn_never_cache(1);

t/server/controller/author.t

@@ -82,33 +82,9 @@ test_psgi app, sub {
     my $json = decode_json_ok($res);
     is( @{ $json->{hits}->{hits} }, 0, '0 results' );
 
-    ok( $res = $cb->( GET '/author/DOY?join=release' ),
-        'GET /author/DOY?join=release' );
-
-    $json = decode_json_ok($res);
-    is( @{ $json->{release}->{hits}->{hits} }, 4, 'joined 4 releases' );
-
-    ok(
-        $res = $cb->(
-            POST '/author/DOY?join=release',
-            Content => encode_json( {
-                query => {
-                    constant_score =>
-                        { filter => { term => { status => 'latest' } } }
-                }
-            } )
-        ),
-        'POST /author/DOY?join=release with query body',
-    );
-
-    $json = decode_json_ok($res);
-    is( @{ $json->{release}->{hits}->{hits} }, 1, 'joined 1 release' );
-    is( $json->{release}->{hits}->{hits}->[0]->{_source}->{status},
-        'latest', '1 release has status latest' );
-
     ok(
         $res = $cb->(
-            POST '/author/_search?join=release',
+            POST '/author/_search',
             Content => encode_json( {
                 query => {
                     constant_score => {
@@ -130,21 +106,14 @@ test_psgi app, sub {
                 }
             } )
         ),
-        'POST /author/_search?join=release with query body'
+        'POST /author/_search with query body'
     );
 
     my $doy = $json;
     $json = decode_json_ok($res);
 
     is( @{ $json->{hits}->{hits} }, 1, '1 hit' );
 
-    my $release_count = delete $doy->{release_count};
-    is_deeply(
-        [ sort keys %{$release_count} ],
-        [qw< backpan-only cpan latest >],
-        'release_count has the correct keys'
-    );
-
     my $links = delete $doy->{links};
     is_deeply(
         [ sort keys %{$links} ],