Don't build coverage report twice

Author: oalders

.circleci/config.yml

@@ -46,21 +46,26 @@ jobs:
             pushd metacpan-docker
             ./src/metacpan-api/wait-for-es.sh http://localhost:9200 elasticsearch_test --
           name: wait for ES
+      # We are running coverage inside the container, but creating the report
+      # from outside of the container, so Devel::Cover is installed twice. We
+      # are relying on environment variables from the host to be available when
+      # we publish the report, so we publish from the host rather than trying
+      # to propagate env variables to the container. There is a CircleCI orb
+      # that can publish the report for us, but it is hard to debug. I had to
+      # set up the following config in order to debug the orb, so we may as
+      # well keep it around for now.
       - run:
           command: |
             pushd metacpan-docker
-            docker-compose exec -T api_test cpm install -g Devel::Cover Devel::Cover::Report::Codecov Devel::Cover::Report::Codecovbash
+            docker-compose exec -T api_test cpm install -g Devel::Cover
           name: install Devel::Cover
       - run:
           command: |
             pushd metacpan-docker
             docker-compose exec -T api_test env HARNESS_PERL_SWITCHES="-MDevel::Cover=+ignore,^t/|^test-data/|^etc/" prove -lr --jobs 2 t
           name: run tests with coverage
-      - run:
-          command: |
-            pushd metacpan-docker
-            docker-compose exec -T api_test cover
-          name: generate coverage report
+      # The report ends up being owned by root. We need to chown it so that
+      # the cover command can make changes to it.
       - run:
           command: |
             pushd metacpan-docker/src/metacpan-api