Skip to content

Commit 7d41d0f

Browse files
committed
Make esx_model attribute private as nothing seems to use it externally
1 parent b1b6ee0 commit 7d41d0f

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

lib/MetaCPAN/Server/Model/CPAN.pm

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,37 +7,30 @@ use MetaCPAN::Server::Config ();
77

88
extends 'Catalyst::Model';
99

10-
has esx_model => (
10+
has _esx_model => (
1111
is => 'ro',
1212
lazy => 1,
13-
builder => '_build_esx_model',
1413
handles => ['es'],
14+
default => sub {
15+
MetaCPAN::Model->new(
16+
es => MetaCPAN::Server::Config::config()->{elasticsearch_servers}
17+
);
18+
},
1519
);
1620

1721
has index => (
1822
is => 'ro',
1923
default => 'cpan',
2024
);
2125

22-
has servers => (
23-
is => 'ro',
24-
default => sub {
25-
return MetaCPAN::Server::Config::config()->{elasticsearch_servers};
26-
},
27-
);
28-
29-
sub _build_esx_model {
30-
MetaCPAN::Model->new( es => shift->servers );
31-
}
32-
3326
sub type {
3427
my $self = shift;
35-
return $self->esx_model->index( $self->index )->type(shift);
28+
return $self->_esx_model->index( $self->index )->type(shift);
3629
}
3730

3831
sub BUILD {
3932
my ( $self, $args ) = @_;
40-
my $index = $self->esx_model->index( $self->index );
33+
my $index = $self->_esx_model->index( $self->index );
4134
my $class = ref $self;
4235
while ( my ( $k, $v ) = each %{ $index->types } ) {
4336
no strict 'refs';

0 commit comments

Comments
 (0)