Merge pull request #1236 from metacpan/haarg/fix-digest-calc

mickeyn · web-flow · commit d3fc66ba5095 · 2024-07-15T16:38:08.000+02:00
fix digest calculation from misuse or tr
diff --git a/lib/MetaCPAN/Server/Controller/CVE.pm b/lib/MetaCPAN/Server/Controller/CVE.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use MetaCPAN::Util qw( digest );
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 
diff --git a/lib/MetaCPAN/Server/Controller/Contributor.pm b/lib/MetaCPAN/Server/Controller/Contributor.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use MetaCPAN::Util qw( digest );
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 
diff --git a/lib/MetaCPAN/Server/Controller/Cover.pm b/lib/MetaCPAN/Server/Controller/Cover.pm
@@ -4,7 +4,6 @@ use strict;
 use warnings;
 
 use Moose;
-use MetaCPAN::Util qw( digest );
 
 BEGIN { extends 'MetaCPAN::Server::Controller' }
 
diff --git a/lib/MetaCPAN/Util.pm b/lib/MetaCPAN/Util.pm
@@ -48,7 +48,7 @@ sub checkout_root {
 
 sub digest {
     my $digest = sha1_base64( join( "\0", grep {defined} @_ ) );
-    $digest =~ tr/[+\/]/-_/;
+    $digest =~ tr{+/}{-_};
     return $digest;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ sub checkout_root {`
`48`	`48`
`49`	`49`	`sub digest {`
`50`	`50`	`my $digest = sha1_base64( join( "\0", grep {defined} @_ ) );`
`51`		`- $digest =~ tr/[+\/]/-_/;`
	`51`	`+ $digest =~ tr{+/}{-_};`
`52`	`52`	`return $digest;`
`53`	`53`	`}`
`54`	`54`