Skip to content

Fix ES syntax - adapt to new version #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mickeyn opened this issue Nov 26, 2024 · 4 comments
Open

Fix ES syntax - adapt to new version #60

mickeyn opened this issue Nov 26, 2024 · 4 comments

Comments

@mickeyn
Copy link
Contributor

mickeyn commented Nov 26, 2024

follow changes in metacpan-api - change all and, / or to bool + must / should.
@mickeyn
Copy link
Contributor Author

mickeyn commented Dec 16, 2024

merged #61

@mickeyn
Copy link
Contributor Author

mickeyn commented Dec 16, 2024

@haarg can you please quickly check if we still have any queries in need of syntax update in this repo?

@haarg
Copy link
Member

haarg commented Dec 16, 2024

Just doing a quick scan, here are some issues:

https://github.com/metacpan/metacpan-ingest/blob/master/bin/backpan.pl#L41
https://github.com/metacpan/metacpan-ingest/blob/master/bin/backpan.pl#L67
https://github.com/metacpan/metacpan-ingest/blob/master/bin/check.pl#L43
https://github.com/metacpan/metacpan-ingest/blob/master/bin/check.pl#L61
https://github.com/metacpan/metacpan-ingest/blob/master/bin/check.pl#L83
https://github.com/metacpan/metacpan-ingest/blob/master/bin/checksum.pl#L32
https://github.com/metacpan/metacpan-ingest/blob/master/bin/checksum.pl#L39
https://github.com/metacpan/metacpan-ingest/blob/master/bin/cve.pl#L150
https://github.com/metacpan/metacpan-ingest/blob/master/bin/favorite.pl#L61
https://github.com/metacpan/metacpan-ingest/blob/master/bin/favorite.pl#L97
https://github.com/metacpan/metacpan-ingest/blob/master/bin/favorite.pl#L122
https://github.com/metacpan/metacpan-ingest/blob/master/bin/favorite.pl#L192
https://github.com/metacpan/metacpan-ingest/blob/master/bin/latest.pl#L334
https://github.com/metacpan/metacpan-ingest/blob/master/bin/suggest.pl#L67
https://github.com/metacpan/metacpan-ingest/blob/master/bin/suggest.pl#L91
https://github.com/metacpan/metacpan-ingest/blob/master/bin/watcher.pl#L191

We should generally not be using fields, and preferring taking data from source. not should be a bool.must_not. And we don't need the payload on the completion field.

@mickeyn
Copy link
Contributor Author

mickeyn commented Dec 16, 2024

@haarg thanks!

I merged #62 fixing the fields usage and the one case of 'not' that was left behind.

I hope the code is now more compatible.

If you have any other cases, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haarg @mickeyn