use separate check for code formatting

Author: haarg

.github/workflows/test.yml

@@ -10,6 +10,39 @@ on:
   workflow_dispatch:
 
 jobs:
+  code-formatting:
+    runs-on: ubuntu-22.04
+    name: Code Formatting
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Fetch base ref
+        if: ${{ github.event.pull_request }}
+        run: git fetch origin ${{ github.base_ref }}:upstream
+      - run: npm install
+      - name: Install Carton
+        uses: perl-actions/install-with-cpm@v1
+        with:
+          install: Carton
+      - name: Install CPAN deps
+        uses: perl-actions/install-with-cpm@v1
+        with:
+          cpanfile: 'cpanfile'
+          args: >
+            --resolver=snapshot
+            --without-runtime
+            --without-test
+            --without-build
+            --with-develop
+      - name: Install precious
+        run: ./bin/install-precious /usr/local/bin
+      - name: Lint modified files
+        if: ${{ github.event.pull_request }}
+        run: precious lint --git-diff-from upstream
+      - name: Lint all files
+        if: ${{ ! github.event.pull_request }}
+        run: precious lint --all
   docker:
     runs-on: ubuntu-22.04
     name: Docker
@@ -40,8 +73,6 @@ jobs:
         DEVEL_COVER_OPTIONS: '-ignore,^local/'
     steps:
       - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
         if: matrix.resolver == 'snapshot'
       - uses: actions/checkout@v4
         if: matrix.resolver != 'snapshot'
@@ -91,17 +122,3 @@ jobs:
           fail_ci_if_error: true
           file: ./cover_db/codecov.json
           token: ${{ secrets.CODECOV_TOKEN }}
-      - name: Install precious
-        run: ./bin/install-precious /usr/local/bin
-      - name: Install perlimports
-        run: cpm install -g App::perlimports
-        if: matrix.resolver == 'snapshot'
-      - name: Fetch master
-        run: git fetch origin master:master
-        if: github.ref != 'refs/heads/master' && matrix.resolver == 'snapshot'
-      - name: Lint files in diff (branch)
-        run: precious lint -d master
-        if: github.ref != 'refs/heads/master' && matrix.resolver == 'snapshot'
-      - name: Lint all files (master)
-        run: precious lint --all
-        if: github.ref == 'refs/heads/master' && matrix.resolver == 'snapshot'

.github/workflows/update-snapshot.yml

@@ -64,6 +64,7 @@ jobs:
           --resolver metacpan
           --show-build-log-on-failure
           --local-lib-contained=local
+          --with-develop
       - name: Maybe update cpanfile.snapshot
         run: carton
       - name: Create Pull Request

cpanfile

@@ -34,7 +34,6 @@ requires 'Gazelle';
 requires 'Getopt::Long::Descriptive';
 requires 'HTML::Escape';
 requires 'HTML::Restrict', '2.2.2';
-requires 'HTML::Tree';
 requires 'HTTP::Message::PSGI';
 requires 'HTTP::Request';
 requires 'HTTP::Request::Common';
@@ -90,14 +89,18 @@ requires 'With::Roles', '0.001002';
 requires 'WWW::Form::UrlEncoded::XS';
 requires 'XML::FeedPP';
 
-# Test dependencies
-requires 'aliased', '0.34';
-requires 'App::Prove';
-requires 'Perl::Critic', '1.136';
-requires 'Perl::Tidy' => '20230909';
-requires 'Test::Code::TidyAll';
-requires 'Test::More', '0.96';
-requires 'Test::Needs';
-requires 'Test::Perl::Critic';
-requires 'Test::Warnings';
-requires 'Test::XPath', '0.15';
+on test => sub {
+    requires 'App::Prove';
+    requires 'HTML::Tree';
+    requires 'Test::More', '0.96';
+    requires 'Test::Warnings';
+    requires 'Test::XPath', '0.15';
+    requires 'aliased', '0.34';
+};
+
+on develop => sub {
+    requires 'App::perlimports';
+    requires 'Perl::Critic', '1.136';
+    requires 'Perl::Tidy' => '20230909';
+    requires 'Test::Vars';
+};