Merge pull request #3046 from metacpan/haarg/fix-build-workflows

fix build workflows to run tests properly with new Dockerfile setup

Author: haarg

.github/workflows/build-deployment-container.yml

@@ -12,14 +12,21 @@ jobs:
     name: Docker Push
     steps:
       - uses: actions/checkout@v3
-      - name: Docker build
-        run: docker build . -t metacpan/metacpan-web:$GITHUB_SHA
-      - name: Run Perl tests
-        run: docker run -i metacpan/metacpan-web carton exec prove -lr --jobs 2 t
       - name: Log in to Docker Hub
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKER_HUB_USER }}
           password: ${{ secrets.DOCKER_HUB_TOKEN }}
-      - name: Push build to Docker hub
-        run: docker push metacpan/metacpan-web:$GITHUB_SHA
+      - name: Build test image
+      - uses: docker/build-push-action@v2
+        with:
+          tags: metacpan/metacpan-web:test
+          target: test
+          push: false
+      - name: Run Perl tests
+        run: docker run -i metacpan/metacpan-web:test
+      - name: Build and push
+        uses: docker/build-push-action@v5
+        with:
+          push: true
+          tags: metacpan/metacpan-web:$GITHUB_SHA

.github/workflows/build-production-container.yml

@@ -11,14 +11,21 @@ jobs:
     name: Docker Push
     steps:
       - uses: actions/checkout@v3
-      - name: docker build
-        run: docker build . -t metacpan/metacpan-web:latest -t metacpan/metacpan-web:$GITHUB_SHA
-      - name: run Perl tests
-        run: docker run -i metacpan/metacpan-web carton exec prove -lr --jobs 2 t
       - name: Log in to Docker Hub
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKER_HUB_USER }}
           password: ${{ secrets.DOCKER_HUB_TOKEN }}
-      - name: Push build to Docker Hub
-        run: docker push --all-tags metacpan/metacpan-web
+      - name: Build test image
+      - uses: docker/build-push-action@v2
+        with:
+          tags: metacpan/metacpan-web:test
+          target: test
+          push: false
+      - name: Run Perl tests
+        run: docker run -i metacpan/metacpan-web:test
+      - name: Build and push
+        uses: docker/build-push-action@v5
+        with:
+          push: true
+          tags: metacpan/metacpan-web:latest,metacpan/metacpan-web:$GITHUB_SHA

Dockerfile

@@ -124,7 +124,7 @@ COPY .perlcriticrc .perltidyrc perlimports.toml tidyall.ini ./
 COPY t t
 
 USER metacpan
-CMD [ "prove", "-lr", "t" ]
+CMD [ "prove", "-l", "-r", "-j", "2", "t" ]
 
 ################### Production Server
 FROM server AS production