rewrite profile page javascript to be bundled, and avoid jquery #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const input = link.parentNode.previousElementSibling; | ||
| console.log(link); | ||
| console.log(input); | ||
| link.href = url.replace('%s', input.value); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML
There was a problem hiding this comment.
Copilot says:
link.href = url.replace('%s', encodeURIComponent(input.value));
haarg
force-pushed
the
haarg/profile-no-jquery
branch
from
22f0774 to
41e881e
Compare
haarg
force-pushed
the
haarg/profile-no-jquery
branch
from
41e881e to
a7f8f89
Compare
dhogan8
approved these changes
Apr 17, 2024
|
That warning is partly wrong, but also already applies to the existing code. I am confident enough in the rest of our code that I don't feel the need to address it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.