oalders/precious #3048
Merged
oalders/precious #3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oalders
commented
May 3, 2024
oalders
commented
- Add precious config
- Add script to install precious in Docker
oalders
force-pushed
the
oalders/precious
branch
2 times, most recently
from
8c408b0 to
4b2e560
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3048 +/- ##
==========================================
- Coverage 71.87% 71.75% -0.12%
==========================================
Files 70 70
Lines 2414 2411 -3
Branches 338 338
==========================================
- Hits 1735 1730 -5
- Misses 554 555 +1
- Partials 125 126 +1
|
oalders
force-pushed
the
oalders/precious
branch
10 times, most recently
from
80c78f8 to
34b8d9e
Compare
haarg
reviewed
May 12, 2024
| @@ -83,3 +88,17 @@ jobs: | |||
| run: cover -report codecov | |||
| env: | |||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | |||
| - name: Install precious | |||
There was a problem hiding this comment.
Don't we want this to be in a separate job, so it's shown as a separate status check?
haarg
previously approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.