Skip to content

add LPW information to banner #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

leejo
Copy link
Contributor

@leejo leejo commented May 3, 2024

PTS is now over and LPW is looking for attendees and sponsors after a five year break. w/r/t d34b6a9

@oalders
Copy link
Member

oalders commented May 3, 2024

@dhogan8 I was thinking maybe we could use a different bg colour here to distinguish this banner from the previous one. Any thoughts on that?

@dhogan8
Copy link
Contributor

dhogan8 commented May 3, 2024

@oalders I haven't spun up the dev environment for this branch yet, but is this replacing the The Perl Toolchain Summit needs more sponsors.... banner or going underneath it?

@oalders
Copy link
Member

oalders commented May 3, 2024

@dhogan8 this will be replacing it. That banner was removed in a previous commit, but it hasn't been deployed yet. My concern is that if it looks a lot like the previous banner, people won't pay attention to it.

@dhogan8
Copy link
Contributor

dhogan8 commented May 3, 2024

How about #006081?
Screenshot 2024-05-03 at 9 54 00 AM

@leejo leejo force-pushed the lpw/add_banner branch from 16563b5 to fa498c1 Compare May 3, 2024 17:54
@leejo
Copy link
Contributor Author

leejo commented May 3, 2024

I've amended the commit to tweak the background colour to #006081 👍

@oalders oalders requested a review from dhogan8 May 3, 2024 18:39
@dhogan8 dhogan8 enabled auto-merge May 6, 2024 21:32
PTS is now over and LPW is looking for attendees and sponsors after a
five year break. w/r/t d34b6a9

tweak the background colour to distinguish between this and previous one
auto-merge was automatically disabled May 7, 2024 07:41

Head branch was pushed to by a user without write access

@leejo leejo force-pushed the lpw/add_banner branch from fa498c1 to 80efe87 Compare May 7, 2024 07:41
@leejo
Copy link
Contributor Author

leejo commented May 7, 2024

Rebased my branch against upstream master

@leejo leejo requested a review from dhogan8 May 7, 2024 08:13
@haarg haarg enabled auto-merge May 7, 2024 12:16
@leejo
Copy link
Contributor Author

leejo commented May 7, 2024

Looks like there's some issue in the CI related to code coverage uploads?

@oalders oalders disabled auto-merge May 7, 2024 13:30
@oalders oalders merged commit ed0f6ea into metacpan:master May 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants