Skip to content

show search hits at page top #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Conversation

JordanEdward02
Copy link

Adds the number of search hits and some formatting to the top of the search page for #2907

@JordanEdward02 JordanEdward02 force-pushed the jordanedward/show-search-hits-at-top branch from 6de1153 to bccd730 Compare May 2, 2025 09:53
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.31%. Comparing base (a25a15b) to head (232029a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3325   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          68       68           
  Lines        2387     2387           
  Branches      335      335           
=======================================
  Hits         1750     1750           
  Misses        509      509           
  Partials      128      128           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guest20
Copy link

guest20 commented May 2, 2025

Can you also change the "results per page" to not look exactly like the pagination controls when I'm not wearing my glasses?

@JordanEdward02
Copy link
Author

Can you also change the "results per page" to not look exactly like the pagination controls when I'm not wearing my glasses?

I'm not sure I understand what you mean. Could you raise a separate issue with some images to highlight the problem please?

@guest20
Copy link

guest20 commented May 2, 2025

There are two already - #1686 #2218

It's about this control, which is a pagination widget being used for non-pagination related purposes:
image

Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JordanEdward02!

@oalders oalders force-pushed the jordanedward/show-search-hits-at-top branch from bccd730 to 232029a Compare May 2, 2025 22:07
@oalders oalders enabled auto-merge May 2, 2025 22:07
@oalders oalders merged commit 7443017 into master May 2, 2025
8 checks passed
@oalders oalders deleted the jordanedward/show-search-hits-at-top branch May 2, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would be nice to show the number of search hits at the top of the page
3 participants