Skip to content

Proposed patch for issue #3278 #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

manwar
Copy link
Contributor

@manwar manwar commented May 1, 2025

Hi Team.

Here is another issue dealt with.

BackPAN link not pointing to BackPAN
https://metacpan.org/author/TONYC

Please review when you get time.

Many Thanks.

Best Regards.
Mohammad

Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.30%. Comparing base (d2d6206) to head (cede9b3).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
lib/MetaCPAN/Web/Controller/Author.pm 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3327      +/-   ##
==========================================
- Coverage   73.31%   73.30%   -0.01%     
==========================================
  Files          68       68              
  Lines        2387     2390       +3     
  Branches      335      336       +1     
==========================================
+ Hits         1750     1752       +2     
  Misses        509      509              
- Partials      128      129       +1     
Files with missing lines Coverage Δ
lib/MetaCPAN/Web/Controller/Author.pm 92.00% <66.66%> (-1.62%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haarg
Copy link
Member

haarg commented May 1, 2025

I believe this is better handled in the API. We also want to link to metacpan's mirror as the backpan.

Here is an alternate fix for this: metacpan/metacpan-api#1375

@oalders
Copy link
Member

oalders commented May 3, 2025

@manwar can you confirm that the merged PR on the API side fixes this?

@oalders
Copy link
Member

oalders commented May 3, 2025

Closing as our behaviour around BackPAN links has changed.

@oalders oalders closed this May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants