Skip to content

Proposed patch for issue 3108 #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged

Conversation

manwar
Copy link
Contributor

@manwar manwar commented May 2, 2025

Hi Team,

Please review the small patch when you get time.

Added attribute "alt" with value "Activity Graph" to the img element.
https://metacpan.org/pod/Test2

Many Thanks.
Best Regards,
Mohammad

@@ -1,4 +1,4 @@
<div class="activity-graph">
<img src="[% $url %]?res=month" />
<img src="[% $url %]?res=month" alt="Activity Graph"/>
Copy link

@guest20 guest20 May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bad alt text. It just repeats the heading directly above it without replacing the information presented in the graph.

One option would be to count the number of groups in the graph and describe how high each of them are.

The other choice is to alt it as "Changes" and link to the whole thing to the Changes file

Edit I think the purpose of the graph is to show how much activity there is, and how recently, so maybe

Maybe join,map"%i release(s) in the last %s" with counts for week/month/year/all time before that would work for that?

    Added attribute "alt" with value "Activity Graph" to the img element.
    https://metacpan.org/pod/Test2
@oalders oalders force-pushed the patch-for-issue-3108 branch from a78e48e to bf22213 Compare May 3, 2025 08:25
@oalders oalders enabled auto-merge May 3, 2025 08:26
@oalders oalders merged commit c397d8f into metacpan:master May 3, 2025
7 checks passed
Copy link

codecov bot commented May 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.48%. Comparing base (7443017) to head (bf22213).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
+ Coverage   73.31%   73.48%   +0.16%     
==========================================
  Files          68       68              
  Lines        2387     2387              
  Branches      335      335              
==========================================
+ Hits         1750     1754       +4     
+ Misses        509      507       -2     
+ Partials      128      126       -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants