Upgrade bootstrap to 5.3.5 and remove ttip package #3336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the ttip package is just a start at removing jquery as a dependency. The browser can handle titles itself to create popups so I have just migrated them to use that instead. We still have a couple of jquery uses in the code: - quick command modal popup - Dropdown menu for the login and profile button These are not trivial to remove unlike ttip so I will not include them in this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the ttip package is just a start at
removing jquery as a dependency. The browser
can handle titles itself to create popups so I
have just migrated them to use that instead.
We still have a couple of jquery uses in the code:
These are not trivial to remove unlike ttip so
I will not include them in this branch
Examples of the revised tooltips: