Skip to content

Proposed patch for issue 3235 #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged

Conversation

manwar
Copy link
Contributor

@manwar manwar commented May 3, 2025

Hi Team,

Please review this tricky one.

Explicitly setting size to 500 to override the default size 250.
https://metacpan.org/author/SYP

Many Thanks.

Best Regards,
Mohammad

Copy link

codecov bot commented May 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.49%. Comparing base (afb9fa5) to head (1db6d9c).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3337      +/-   ##
==========================================
- Coverage   73.56%   73.49%   -0.08%     
==========================================
  Files          68       68              
  Lines        2387     2388       +1     
  Branches      335      335              
==========================================
- Hits         1756     1755       -1     
- Misses        506      507       +1     
- Partials      125      126       +1     
Files with missing lines Coverage Δ
lib/MetaCPAN/Web/Controller/Author.pm 93.75% <100.00%> (+0.13%) ⬆️
lib/MetaCPAN/Web/Model/API/Favorite.pm 62.22% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manwar manwar force-pushed the patch-for-issue-3235 branch from be91fe6 to 85fe36a Compare May 3, 2025 15:10
    Explicitly setting size to 500 to override the default size 250.
    https://metacpan.org/author/SYP
@manwar manwar force-pushed the patch-for-issue-3235 branch from 85fe36a to 1db6d9c Compare May 3, 2025 15:17
Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@oalders oalders added this pull request to the merge queue May 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 3, 2025
@oalders oalders merged commit 49fe566 into metacpan:master May 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants