Skip to content

Change configuration file name #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025

Conversation

ehuelsmann
Copy link
Contributor

The old instructions are not valid YAML.

@haarg
Copy link
Member

haarg commented May 24, 2025

The existing instructions aren't really wrong. Using a metacpan_web_local.conf file using Config::General syntax should still work.

The file name also needs to be updated with the format.

@ehuelsmann ehuelsmann changed the title Change metacpan_web_local.yml instructions Change configuration file name May 24, 2025
@ehuelsmann
Copy link
Contributor Author

The file name also needs to be updated with the format.

The confusion came from the fact that - although the docs list metacpan_web.conf, there actually is only a metacpan_web.yaml. All I did was add the _local suffix to the filename on disk (that is, before the extension), which resulted in metacpan_web_local.yaml instead of the documented metacpan_web_local.conf.

@ehuelsmann
Copy link
Contributor Author

Indeed, both work (I've tested that now).

@haarg
Copy link
Member

haarg commented May 24, 2025

I think we should change the example to also use YAML, like you originally had. But both file names need their extensions changed.

I just wanted to clarify that a _local.conf will still work. But we don't need it in the docs.

The old instructions are not valid YAML.
@ehuelsmann ehuelsmann force-pushed the update-readme-local-yaml branch from 9c79a2f to 30160b1 Compare May 24, 2025 15:05
@ehuelsmann
Copy link
Contributor Author

Ah! No problem. Reverted the last change (reinstating metacpan_web_local.yaml) and changed the base name of the standard configuration to metacpan_web.yaml as it is on disk.

@guest20
Copy link

guest20 commented May 24, 2025

The reason to not use YAML for the config of Catalyst apps is that putting YAML in POD is pure hate‡.

Both pod and YAML use different indents to indicate stuff and so:

  • editors will assume that the whole expanse of space is the same type of space and any edit will turn your 4 spaces for pod indent, 6 spaces for 3 levels of keys in yaml into a factor of tabstop
  • different renders care different amounts about whitespace, so now the manual looks weird on ancient BSD or the latest macos
  • copy/pasting example YAML configs from the pod (rendered or otherwise) pretty much never works because of different levels of collapsing space or because of non-breaking spaces being forced in so it renders right. Maybe the renderer doesn't strip the leading "this is a verbatim block" spaces

... nearly all of this is also true for pasting yaml into markdown, a thing which people will likely need to do if they ever have to report a bug

__
‡. when are we getting =yaml in pod?

@oalders
Copy link
Member

oalders commented May 24, 2025

I think we should change the example to also use YAML

+1 Let's not encourage any config formats other than YAML. We were in a transitional state there for a while, but now it's time for the docs to catch up.

Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (dd7274a) to head (30160b1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3361      +/-   ##
==========================================
+ Coverage   73.41%   73.46%   +0.04%     
==========================================
  Files          68       68              
  Lines        2389     2389              
  Branches      335      335              
==========================================
+ Hits         1754     1755       +1     
+ Misses        508      507       -1     
  Partials      127      127              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oalders oalders added this pull request to the merge queue May 25, 2025
@oalders
Copy link
Member

oalders commented May 25, 2025

Thanks @ehuelsmann!

Merged via the queue into metacpan:master with commit 7d6b57e May 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants