-
Notifications
You must be signed in to change notification settings - Fork 237
Change configuration file name #3361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The existing instructions aren't really wrong. Using a The file name also needs to be updated with the format. |
The confusion came from the fact that - although the docs list |
Indeed, both work (I've tested that now). |
I think we should change the example to also use YAML, like you originally had. But both file names need their extensions changed. I just wanted to clarify that a |
The old instructions are not valid YAML.
9c79a2f
to
30160b1
Compare
Ah! No problem. Reverted the last change (reinstating |
The reason to not use YAML for the config of Catalyst apps is that putting YAML in POD is pure hate‡. Both pod and YAML use different indents to indicate stuff and so:
... nearly all of this is also true for pasting yaml into markdown, a thing which people will likely need to do if they ever have to report a bug __ |
+1 Let's not encourage any config formats other than YAML. We were in a transitional state there for a while, but now it's time for the docs to catch up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3361 +/- ##
==========================================
+ Coverage 73.41% 73.46% +0.04%
==========================================
Files 68 68
Lines 2389 2389
Branches 335 335
==========================================
+ Hits 1754 1755 +1
+ Misses 508 507 -1
Partials 127 127 🚀 New features to boost your workflow:
|
Thanks @ehuelsmann! |
The old instructions are not valid YAML.