feat: Thread support #118
Merged
feat: Thread support #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… against reentrancy problems in event_hook_raw
… the execution of event_hook_raw() in the same thread
…ng the logging of a thread.join line
…s, because their parameter is variable (contains a thread id, which is different on every program run)
alehander92
reviewed
Sep 19, 2025
| return; | ||
| } | ||
|
|
||
| let thread_id: u64 = rb_eval_string(c"Thread.current".as_ptr() as *const c_char) |
There was a problem hiding this comment.
discussed in discord chat: writing again one question here, sorry for repeating: isn't this slow: to evaluate it as ruby code : it seems we can access the thread_id in other places from *const rb_internal_thread_event_data_t, probably here we can't access something like that?
There was a problem hiding this comment.
The thread ID is not directly available in the structure, passed by address to this callback function. It is possible to reach it, but you need to follow pointers to internal Ruby interpreter structures, and I'm not sure if these are stable, since they're not part of the public API, and will probably change often with Ruby versions.
Benchmark Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.