From 665fa8a215b9068a7856774fee0b200d7ab03b57 Mon Sep 17 00:00:00 2001
From: zah <zahary@gmail.com>
Date: Sun, 29 Jun 2025 17:38:16 +0300
Subject: [PATCH] refactor: use inline styles in benchmark SVG

---
 .agents/tasks/2025/06/29-1410-svg-report-cleanup |  1 +
 .gitignore                                       |  2 ++
 test/benchmarks/run_benchmarks.rb                | 16 +++++++++++-----
 3 files changed, 14 insertions(+), 5 deletions(-)
 create mode 100644 .agents/tasks/2025/06/29-1410-svg-report-cleanup

diff --git a/.agents/tasks/2025/06/29-1410-svg-report-cleanup b/.agents/tasks/2025/06/29-1410-svg-report-cleanup
new file mode 100644
index 0000000..ebd01fe
--- /dev/null
+++ b/.agents/tasks/2025/06/29-1410-svg-report-cleanup
@@ -0,0 +1 @@
+In the benchmark’s SVG report, there is an unwanted style definition appearing in the automatically inserted GitHub comment. Clean it up and improve the table aesthetics.
diff --git a/.gitignore b/.gitignore
index 40499c5..bf51260 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,6 +3,8 @@
 !test/fixtures/*.json
 !test/benchmarks/fixtures/*.json
 test/tmp/
+reports/
+test/benchmarks/tmp/
 .direnv/
 .idea/
 pkg/
diff --git a/test/benchmarks/run_benchmarks.rb b/test/benchmarks/run_benchmarks.rb
index 6604544..8d9e88b 100755
--- a/test/benchmarks/run_benchmarks.rb
+++ b/test/benchmarks/run_benchmarks.rb
@@ -177,16 +177,22 @@ def run_benchmark(name)
     height     = 40 + row_height * results.size
     svg = +"<svg xmlns='http://www.w3.org/2000/svg' width='700' height='#{height}'>\n"
     svg << "  <foreignObject width='100%' height='100%'>\n"
-    svg << "    <style>table{border-collapse:collapse;font-family:sans-serif;}td,th{border:1px solid #999;padding:4px;text-align:center;}</style>\n"
-    svg << "    <table>\n"
-    svg << "      <thead><tr><th>#{COLUMN_NAMES[:benchmark]}</th><th>#{COLUMN_NAMES[:ruby]}</th><th>#{COLUMN_NAMES[:json]}</th><th>#{COLUMN_NAMES[:capnp]}</th><th>#{COLUMN_NAMES[:pure]}</th></tr></thead>\n"
+    cell_style = "style='border:1px solid #999;padding:4px;text-align:center;'"
+    svg << "    <table style='border-collapse:collapse;font-family:sans-serif;'>\n"
+    svg << "      <thead><tr>"
+    svg << "<th #{cell_style}>#{COLUMN_NAMES[:benchmark]}</th>"
+    svg << "<th #{cell_style}>#{COLUMN_NAMES[:ruby]}</th>"
+    svg << "<th #{cell_style}>#{COLUMN_NAMES[:json]}</th>"
+    svg << "<th #{cell_style}>#{COLUMN_NAMES[:capnp]}</th>"
+    svg << "<th #{cell_style}>#{COLUMN_NAMES[:pure]}</th></tr></thead>\n"
     svg << "      <tbody>\n"
-    results.each do |r|
+    results.each_with_index do |r, idx|
+      row_style = idx.odd? ? " style='background:#f0f0f0;'" : ''
       ruby_s = "#{r[:ruby_ms]}ms"
       json_s = "#{r[:native_ok] ? '✓' : '✗'} #{r[:native_ms]}ms"
       capnp_s = "#{r[:native_bin_ms]}ms"
       pure_s = "#{r[:pure_ok] ? '✓' : '✗'} #{r[:pure_ms]}ms"
-      svg << "        <tr><td>#{r[:name]}</td><td>#{ruby_s}</td><td>#{json_s}</td><td>#{capnp_s}</td><td>#{pure_s}</td></tr>\n"
+      svg << "        <tr#{row_style}><td #{cell_style}>#{r[:name]}</td><td #{cell_style}>#{ruby_s}</td><td #{cell_style}>#{json_s}</td><td #{cell_style}>#{capnp_s}</td><td #{cell_style}>#{pure_s}</td></tr>\n"
     end
     svg << "      </tbody>\n"
     svg << "    </table>\n"