Skip to content

Conversation

@MartinNikov
Copy link
Collaborator

  • nethermind: 1.30.3 > 1.31.0
  • geth: 1.15.0 > 1.15.2
  • mev-boost: 1.8 > 1.9-rc2
  • web3signer: 24.6.0 > 25.2.0
  • nimbus: 25.1.0 > 25.2.0

Copy link

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with this PR but have not tested it.

@jakubgs
Copy link

jakubgs commented Feb 20, 2025

There is an incorrect hash for nimbus-eth2 source in pkgs/nimbus/default.nix:

       error: hash mismatch in fixed-output derivation '/nix/store/22iaddgnc87gw22869vjkr7p65x5a4b3-source.drv':
         specified: sha256-aPyfbQ1983jaWL2XI0yyLHXYegIPT7ugPbFfid5pkfo=
            got:    sha256-INALxgkuZ4kT/DrpzMBqgNeM8Ar78BRccmGWtqoGhB0=

@github-actions
Copy link

Thanks for your Pull Request!

This comment will be updated automatically with the status of each package.

@PetarKirov
Copy link
Collaborator

There is an incorrect hash for nimbus-eth2 source in pkgs/nimbus/default.nix:

       error: hash mismatch in fixed-output derivation '/nix/store/22iaddgnc87gw22869vjkr7p65x5a4b3-source.drv':
         specified: sha256-aPyfbQ1983jaWL2XI0yyLHXYegIPT7ugPbFfid5pkfo=
            got:    sha256-INALxgkuZ4kT/DrpzMBqgNeM8Ar78BRccmGWtqoGhB0=

That's odd as I got sha256-aPyfbQ1983jaWL2XI0yyLHXYegIPT7ugPbFfid5pkfo= as well:

nurl -S https://github.com/status-im/nimbus-eth2 v25.2.0
$ nix flake prefetch --extra-experimental-features 'nix-command flakes' --json git+https://github.com/status-im/nimbus-eth2?ref=refs/tags/v25.2.0&submodules=1
fetchFromGitHub {
  owner = "status-im";
  repo = "nimbus-eth2";
  rev = "v25.2.0";
  hash = "sha256-aPyfbQ1983jaWL2XI0yyLHXYegIPT7ugPbFfid5pkfo=";
  fetchSubmodules = true;
}

I'll try the same with fake hash to see if I get sha256-INALxgkuZ4kT/DrpzMBqgNeM8Ar78BRccmGWtqoGhB0=.

@MartinNikov MartinNikov merged commit 3b34218 into dev Feb 21, 2025
4 of 6 checks passed
@MartinNikov MartinNikov deleted the update/packages branch February 21, 2025 09:55
@PetarKirov
Copy link
Collaborator

Okay, I've reproduced the hash by using the fakeHash approach:

image

I've then compared the outputs of the 2 fixed-output-derivation expressions:

image

Diffing the individual files shows that these obtained via

nix flake prefetch --json git+https://github.com/status-im/nimbus-eth2?ref=refs/tags/v25.2.0&submodules=1

have Unix line endings (LF), while these obtained via:

pkgs.fetchFromGitHub {
  owner = "status-im";
  repo = "nimbus-eth2";
  rev = "v25.2.0";
  hash = "sha256-INALxgkuZ4kT/DrpzMBqgNeM8Ar78BRccmGWtqoGhB0";
  fetchSubmodules = true;
}

have Windows line endings CRLF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants