Extract field path separator into shared constant.

Author: blackwinter

metafix/src/main/java/org/metafacture/metafix/FixMethod.java

@@ -170,7 +170,7 @@ public void apply(final Metafix metafix, final Record record, final List<String>
             final String field = params.get(0);
             final Value newValue = newArray(params.subList(1, params.size()).stream().map(Value::new));
             record.set(field, newValue);
-            newValue.asArray().forEach(value -> value.withPathSet(newValue.getPath() + "." + value.getPath()));
+            newValue.asArray().forEach(value -> value.withPathSet(newValue.getPath() + Value.FIELD_PATH_SEPARATOR + value.getPath()));
         }
     },
     add_field {

metafix/src/main/java/org/metafacture/metafix/FixPath.java

@@ -34,6 +34,10 @@
 /*package-private*/ class FixPath {
 
     private static final String ASTERISK = "*";
+
+    private static final String INDEX_SUBPATH_PATTERN = Value.FIELD_PATH_SEPARATOR_PATTERN + "\\d" + Value.FIELD_PATH_SEPARATOR_PATTERN;
+    private static final String ASTERISK_SUBPATH = Value.FIELD_PATH_SEPARATOR + ASTERISK + Value.FIELD_PATH_SEPARATOR;
+
     private String[] path;
 
     /*package-private*/ FixPath(final String path) {
@@ -111,7 +115,7 @@ private Value findInValue(final Value value, final String[] p) {
 
     @Override
     public String toString() {
-        return String.join(".", path);
+        return String.join(Value.FIELD_PATH_SEPARATOR, path);
     }
 
     /*package-private*/ int size() {
@@ -141,7 +145,9 @@ else if (value.getPath() != null && hasWildcard()) {
     }
 
     private boolean matches(final String thatPath) {
-        return thatPath != null && thatPath.replaceAll("\\.\\d+\\.", ".*.").equals(String.join(".", this.path));
+        return thatPath != null && thatPath
+            .replaceAll(INDEX_SUBPATH_PATTERN, ASTERISK_SUBPATH)
+            .equals(String.join(Value.FIELD_PATH_SEPARATOR, this.path));
     }
 
     private String[] replaceInPath(final String find, final int i) {

metafix/src/main/java/org/metafacture/metafix/Value.java

@@ -52,7 +52,8 @@
  */
 public class Value implements JsonValue { // checkstyle-disable-line ClassDataAbstractionCoupling
 
-    private static final String FIELD_PATH_SEPARATOR = "\\.";
+    public static final String FIELD_PATH_SEPARATOR = ".";
+    /*package-private*/ static final String FIELD_PATH_SEPARATOR_PATTERN = Pattern.quote(FIELD_PATH_SEPARATOR);
 
     private final Array array;
     private final Hash hash;
@@ -409,7 +410,7 @@ public void toJson(final JsonGenerator jsonGenerator) {
     }
 
     /*package-private*/ static String[] split(final String fieldPath) {
-        return fieldPath.split(FIELD_PATH_SEPARATOR);
+        return fieldPath.split(FIELD_PATH_SEPARATOR_PATTERN);
     }
 
     /**
@@ -431,7 +432,7 @@ private Value withPathAppend(final int i) {
     }
 
     private Value withPathAppend(final String field) {
-        return withPathSet(path == null || path.isEmpty() ? field : path + "." + field);
+        return withPathSet(path == null || path.isEmpty() ? field : path + FIELD_PATH_SEPARATOR + field);
     }
 
     /*package-private*/ Value copy() {
@@ -574,7 +575,7 @@ protected <T> Map<T, Collection<String>> retainFields(final Collection<String> f
             final Map<T, Collection<String>> retainFields = new HashMap<>();
 
             fields.forEach(p -> {
-                final String[] parts = p.split(FIELD_PATH_SEPARATOR, 2);
+                final String[] parts = p.split(FIELD_PATH_SEPARATOR_PATTERN, 2);
 
                 function.apply(parts[0]).forEach(f -> {
                     final Collection<String> retainNested = retainFields.computeIfAbsent(f, k -> new HashSet<>());