Skip to content

Commit e988cfe

Browse files
committed
Improved documentation of assembly construction
1 parent f6a8a87 commit e988cfe

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

pom.xml

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,20 @@
222222
<version>2.0.0-SNAPSHOT</version>
223223
</dependency>
224224

225-
<dependency>
226-
<groupId>org.slf4j</groupId>
227-
<artifactId>slf4j-api</artifactId>
228-
<version>1.7.6</version>
229-
</dependency>
230-
225+
<!-- The following dependencies are placed in the "provided"
226+
scope to prevent them from being included in the class
227+
path but still have them available for building the
228+
distribution assembly.
229+
The reason for this is that appropriate implementations
230+
for slf4j and jndi depend on the runtime environment and
231+
should be chosen by the user of the package and not the
232+
package implementer. However, since we are not also
233+
building a distribution package which should include
234+
everything that is required for metafacture-runner/Flux
235+
to work out of the box. By including the dependencies
236+
in the assembly without putting them on the class path,
237+
the user can replace them easily with other
238+
implementations if necessary. -->
231239
<dependency>
232240
<groupId>org.slf4j</groupId>
233241
<artifactId>slf4j-log4j12</artifactId>
@@ -243,6 +251,7 @@
243251
</dependency>
244252

245253
<dependency>
254+
<!-- Required for connection pooling with simple-jndi -->
246255
<groupId>commons-dbcp</groupId>
247256
<artifactId>commons-dbcp</artifactId>
248257
<version>1.4</version>

0 commit comments

Comments
 (0)