File tree Expand file tree Collapse file tree 1 file changed +15
-6
lines changed Expand file tree Collapse file tree 1 file changed +15
-6
lines changed Original file line number Diff line number Diff line change 222
222
<version >2.0.0-SNAPSHOT</version >
223
223
</dependency >
224
224
225
- <dependency >
226
- <groupId >org.slf4j</groupId >
227
- <artifactId >slf4j-api</artifactId >
228
- <version >1.7.6</version >
229
- </dependency >
230
-
225
+ <!-- The following dependencies are placed in the "provided"
226
+ scope to prevent them from being included in the class
227
+ path but still have them available for building the
228
+ distribution assembly.
229
+ The reason for this is that appropriate implementations
230
+ for slf4j and jndi depend on the runtime environment and
231
+ should be chosen by the user of the package and not the
232
+ package implementer. However, since we are not also
233
+ building a distribution package which should include
234
+ everything that is required for metafacture-runner/Flux
235
+ to work out of the box. By including the dependencies
236
+ in the assembly without putting them on the class path,
237
+ the user can replace them easily with other
238
+ implementations if necessary. -->
231
239
<dependency >
232
240
<groupId >org.slf4j</groupId >
233
241
<artifactId >slf4j-log4j12</artifactId >
243
251
</dependency >
244
252
245
253
<dependency >
254
+ <!-- Required for connection pooling with simple-jndi -->
246
255
<groupId >commons-dbcp</groupId >
247
256
<artifactId >commons-dbcp</artifactId >
248
257
<version >1.4</version >
You can’t perform that action at this time.
0 commit comments