Skip to content

Conversation

@TobiasNx
Copy link
Contributor

Like this?

Copy link
Member

@dr0i dr0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to explain a bit more.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Apr 10, 2025
@dr0i dr0i moved this to Review in Metafacture Apr 10, 2025
Co-authored-by: Pascal Christoph <christoph@hbz-nrw.de>
@TobiasNx TobiasNx requested a review from dr0i April 10, 2025 08:54
@dr0i
Copy link
Member

dr0i commented Apr 10, 2025

Please fix formatting to make build successful:

README.md:
94: Wrong amount of left-padding spaces(want multiple of 2)

@blackwinter
Copy link
Member

Can't we just get rid of this release detection logic? If you want to make a signed release, explicitly specify a parameter or execute a dedicated task.

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Apr 10, 2025
@dr0i
Copy link
Member

dr0i commented Apr 10, 2025

@blackwinter yes, you could do that. The release logic is overly complicated, so making this more simple would be nice.

@dr0i dr0i removed their assignment Apr 10, 2025
@blackwinter
Copy link
Member

See #684.

@dr0i
Copy link
Member

dr0i commented May 12, 2025

Substituted n favour of #684.

@dr0i dr0i closed this May 12, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in Metafacture May 12, 2025
@dr0i dr0i deleted the tagLocalPublishing branch May 12, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants