WIP: Custom websocket #515
Conversation
lib/server.js
Outdated
|
|
||
| if (balancer) return; | ||
| this.wsServer = new ws.Server({ server: this.httpServer }); | ||
| this.wsServer = new WebsocketServer(this.httpServer); |
There was a problem hiding this comment.
I'd propose to be compatible with ws:
| this.wsServer = new WebsocketServer(this.httpServer); | |
| this.wsServer = new WebsocketServer({ server: this.httpServer }); |
| GOING_AWAY: { | ||
| reason: 'Going away', | ||
| buf: Buffer.from([ | ||
| 0x88, 0xc, 0x3, 0xe9, 0x47, 0x6f, 0x69, 0x6e, 0x67, 0x20, 0x61, 0x77, | ||
| 0x61, 0x79, | ||
| ]), | ||
| }, |
There was a problem hiding this comment.
Let's hold strings as ascii strings and all unprintable as hex, for example:
| GOING_AWAY: { | |
| reason: 'Going away', | |
| buf: Buffer.from([ | |
| 0x88, 0xc, 0x3, 0xe9, 0x47, 0x6f, 0x69, 0x6e, 0x67, 0x20, 0x61, 0x77, | |
| 0x61, 0x79, | |
| ]), | |
| }, | |
| GOING_AWAY: { | |
| reason: 'Going away', | |
| buf: Buffer.concat([ | |
| Buffer.from([0x88, 0x0c, 0x03, 0xe9]), | |
| Buffer.from('Going away', 'utf8'), | |
| ]), | |
| }, |
lib/websocket/frame.js
Outdated
| CLOSE_CODES, | ||
| TWO_32, | ||
| } = require('./constants'); | ||
| const { Result } = require('./utils/result'); |
There was a problem hiding this comment.
Always add extensions in require
| const { Result } = require('./utils/result'); | |
| const { Result } = require('./utils/result.js'); |
lib/websocket/frame.js
Outdated
| module.exports = { | ||
| Frame, | ||
| }; |
There was a problem hiding this comment.
| module.exports = { | |
| Frame, | |
| }; | |
| module.exports = { Frame }; |
| on(event, cb) { | ||
| if (event === 'open') this._openCb = cb; | ||
| else if (event === 'message') this._messageCb = (buf) => cb(buf); | ||
| else if (event === 'frame') this._frameCb = cb; | ||
| else if (event === 'ping') this._pingCb = (buf) => cb(buf); | ||
| else if (event === 'pong') this._pongCb = (buf) => cb(buf); | ||
| else if (event === 'close') this._closeCb = cb; | ||
| } |
There was a problem hiding this comment.
We can just use EventEmitter
There was a problem hiding this comment.
Yes, that’s a good idea — much cleaner than mocking everything. Done
| // Methods: send(data), sendFrame(opcode, payload, { fin=true, mask=true }), | ||
| // sendText, sendBinary, ping, close | ||
| class ProtocolClient { | ||
| constructor(url) { |
There was a problem hiding this comment.
Wery long constructor, maybe we can decompose, for example, extracting collection:
{ [opcode]: [handler] }
| @@ -0,0 +1,35 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Should be moved to metautil
There was a problem hiding this comment.
Should I move the Result class to metautil, or do you think it would be better to introduce an algebraic data types?
2 participants
#476
npm t)npm run fix)