fix: ensure counter metrics include _total suffix in HELP and TYPE lines #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelhe
force-pushed
the
fix-prometheus-help
branch
from
889ce62 to
61354e4
Compare
michelhe
commented
Jul 23, 2025
michelhe
force-pushed
the
fix-prometheus-help
branch
from
61354e4 to
a20e2f7
Compare
The Prometheus exporter now properly appends the _total suffix to counter metric names in both help text and type declarations, ensuring consistency with Prometheus naming conventions. This also makes the python `prometheus_client.parser.text_string_to_metric_families` parse the metrics better. Even though not mandatory by the exposition format, I've seen the prometheus go client append these suffixes to both HELP and TYPE lines. For example see: ```bash docker run -d --rm -p 9090:9090 prom/prometheus curl http://localhost:9090/metrics ``` Signed-off-by: Michel Heily <michelheily@gmail.com>
tobz
added
C-exporter
tobz
added
the
S-awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #596
The Prometheus exporter now properly appends the _total suffix to counter metric names in both help text and type declarations, ensuring consistency with Prometheus naming conventions.
This also makes the python
prometheus_client.parser.text_string_to_metric_familiesparse the metrics better.Even though not mandatory by the exposition format, I've seen the prometheus go client append these suffixes to both HELP and TYPE lines. For example see: