Skip to content

Conversation

djc
Copy link
Contributor

@djc djc commented Oct 9, 2025

The first commit explodes the MSRV checks so that instead of running cargo test for the MSRVs, we run cargo check for (a) the libraries, and (b) the binary against their respective MSRVs. This takes the dev-dependencies out of scope for MSRV checks, which makes life a lot easier.

@djc djc force-pushed the update-deps branch 3 times, most recently from 36a8d10 to 98a0caf Compare October 10, 2025 08:40
@tobz
Copy link
Member

tobz commented Oct 10, 2025

Nice, I like the split between library and binary for MSRV checking. 👍🏻

@tobz tobz added C-util Component: utility classes and helpers. E-simple Effort: simple. T-chore Type: chore. labels Oct 10, 2025
@tobz tobz merged commit 13cbf24 into metrics-rs:main Oct 10, 2025
14 checks passed
@tobz tobz added the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Oct 10, 2025
@djc
Copy link
Contributor Author

djc commented Oct 10, 2025

Thanks for the quick response! Would be nice to get this stuff released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-util Component: utility classes and helpers. E-simple Effort: simple. S-awaiting-release Status: awaiting a release to be considered fixed/implemented. T-chore Type: chore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants