Skip to content

the component acting as "horizontal" when there is a horizontal scroll even if direction="vertical" is set #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m4m205 opened this issue Aug 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@m4m205
Copy link

m4m205 commented Aug 22, 2023

Hello mfuu,

this issue happen when I have a vertical list with one row (or rows not enough to have vertical scroll),
and that row always has a lot of data to show. then when there is horizontal scroll AND no vertical scroll, then the issue happen.

the "bottom" event will be triggered when scrolling to the right (which shouldn't happen). and the list will not update the view correctly when adding a second line.
both lines will be disappear.

thank you in advice for all your efforts.

I know that you are providing this amazing component for free.
but just to put you in the picture, I am using this component in production and now I have a lot of complains from the customers.
if that can be fix quickly then it will be great.

I looked to your code and it look like you always consider 'direction' cases.
nevertheless the issue exist.

if I can help in anyway then please let me know.

@mfuu mfuu added the bug Something isn't working label Aug 23, 2023
@m4m205
Copy link
Author

m4m205 commented Aug 27, 2023

Hello mfuu,

I found the issue.

let's say we have a case with component set to direction="vertical"

in Virtual.js file the function handleScroll will be called even when the scroll horizontally, but with the same "offset" value

then we will have a case with offset === this.offset

I added a fix to my previous pull request (for adding extra Props).
it woke okay for my.

I still not understand what "LEADING_BUFFER" is used for.

and also it causing some rows to disappear when a user add a new row to long list of rows!
(but that to be fixed in another day maybe)

please let me know if you agree with my fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants