Skip to content

Commit a5c38d6

Browse files
committed
fix: looping error
1 parent 6ee7a7d commit a5c38d6

File tree

5 files changed

+25
-8
lines changed

5 files changed

+25
-8
lines changed

.github/workflows/npm-publish.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: npm publish
2+
3+
on:
4+
release:
5+
types: [created]
6+
7+
jobs:
8+
publish-npm:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: actions/checkout@v4
12+
- uses: actions/setup-node@v4
13+
with:
14+
node-version: 18
15+
registry-url: https://registry.npmjs.org/
16+
- run: npm i
17+
- run: npm publish --tag=next
18+
env:
19+
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}

dist/virtual-list.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* vue-virtual-sortable v3.0.2
2+
* vue-virtual-sortable v3.0.3
33
* open source under the MIT license
44
* https://github.com/mfuu/vue3-virtual-sortable#readme
55
*/
@@ -1909,9 +1909,8 @@
19091909
return;
19101910
}
19111911
var sizes = virtual.sizes.size;
1912-
var renders = Math.min(props.keeps, list.value.length);
19131912
virtual.onItemResized(key, size);
1914-
if (sizes === renders - 1) {
1913+
if (sizes === props.keeps - 1 && list.value.length > props.keeps) {
19151914
virtual.updateRange(range.value);
19161915
}
19171916
};

dist/virtual-list.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "vue-virtual-sortable",
3-
"version": "3.0.2",
3+
"version": "3.0.3",
44
"description": "A virtual scrolling list component that can be sorted by dragging, support vue3",
55
"main": "dist/virtual-list.min.js",
66
"types": "types/index.d.ts",

src/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,10 +257,9 @@ const VirtualList = defineComponent({
257257
}
258258

259259
const sizes = virtual.sizes.size;
260-
const renders = Math.min(props.keeps, list.value.length);
261260
virtual.onItemResized(key, size);
262261

263-
if (sizes === renders - 1) {
262+
if (sizes === props.keeps - 1 && list.value.length > props.keeps) {
264263
virtual.updateRange(range.value);
265264
}
266265
};

0 commit comments

Comments
 (0)