Expose *GraphRequest functions
#13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exposed `GraphRequest` and `BasicGraphRequest` functions so not-yet-supported APIs can be manually called. * Support `context` in `*GraphRequest` * Removed redundant code in `GraphRequest` (now calls `BasicGraphRequst` after the inital request prep)
Open
Allows for easy mocking of a `Client` for testing in consuming code.
Changed to use the more idomatic form for the API paths to hit (absolute insead of relative but from the root).
Per the docs, the user is expected to close the response body on non-nil error. See: https://pkg.go.dev/net/http?tab=doc#Client.Do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphRequestandBasicGraphRequestfunctions so not-yet-supported APIs can be manually called.contextin*GraphRequestGraphRequest(now callsBasicGraphRequstafter the inital request prep)